Vulnerability GHSA-9jpv-c7p4-997x

Critical

4 months ago

DIRAC is vulnerable to RCE in RequestManager due to eval on untrusted input

7.2a29 and 7.2.0a32 and 7.2.0a33 and 7.2.0a34 and 7.2.0a35 and 7.2.0a36 and 7.2.0a38 and 7.2.0a39 and 7.2.0 - 7.2.10 and 7.2.12 - 7.2.16 and 7.2.19 - 7.2.28 and 7.2.30 - 7.3.0a2 and 7.3.0a3 and 7.3.0a4 and 7.3.0a5 and 7.3.0a6 and 7.3.0a7 and 7.3.0a8 and 7.3.0a9 and 7.3.0a10 and 7.3.0a11 and 7.3.0a13 and 7.3.0a14 and 7.3.0a15 and 7.3.0a16 and 7.3.0a17 and 7.3.0a18 and 7.3.0a19 and 7.3.0a20 and 7.3.0a21 and 7.3.0a22 and 7.3.0a23 and 7.3.0a24 - 7.3.24 and 7.3.26 - 8.0.0a1 and 8.0.0a5 and 8.0.0a6 and 8.0.0a7 and 8.0.0a8 and 8.0.0a9 and 8.0.0a10 and 8.0.0a11 and 8.0.0a12 and 8.0.0a13 and 8.0.0a14 and 8.0.0a15 and 8.0.0a16 and 8.0.0a17 and 8.0.0a18 and 8.0.0a19 and 8.0.0a20 and 8.0.0a21 and 8.0.0a22 and 8.0.0a23 and 8.0.0a24 and 8.0.0a25 and 8.0.0a26 and 8.0.0a27 and 8.0.0a28 and 8.0.0a29 and 8.0.0 - 8.0.56 and 8.0.58 - 8.1.0a1 and 8.1.0a2 and 8.1.0a3 and 8.1.0a4 and 8.1.0a5 and 8.1.0a6 and 8.1.0a7 and 8.1.0a8 and 8.1.0a9 and 8.1.0a10 and 8.1.0a11 and 8.1.0a12 and 8.1.0a13 and 8.1.0a14 and 8.1.0a15 and 8.1.0a16 and 8.1.0a17 and 8.1.0a18 and 8.1.0a19 and 8.1.0a20 and 8.1.0a21 and 8.1.0a22 and 8.1.0a23 - 9.0.0a1 and 9.0.0a2 and 9.0.0a3 and 9.0.0a4 and 9.0.0a5 and 9.0.0a6 and 9.0.0a10 and 9.0.0a11 and 9.0.0a12 and 9.0.0a13 and 9.0.0a16 and 9.0.0a17 and 9.0.0a18 and 9.0.0a19 and 9.0.0a20 and 9.0.0a21 and 9.0.0a22 and 9.0.0a23 and 9.0.0a24 and 9.0.0a25 and 9.0.0a26 and 9.0.0a27 and 9.0.0a28 and 9.0.0a29 and 9.0.0a30 and 9.0.0a31 and 9.0.0a35 and 9.0.0a36 and 9.0.0a37 and 9.0.0a38 and 9.0.0a39 and 9.0.0a40 and 9.0.0a41 and 9.0.0a42 and 9.0.0a43 and 9.0.0a44 and 9.0.0a45 and 9.0.0a46 and 9.0.0a47 and 9.0.0a48 and 9.0.0a49 and 9.0.0a50 and 9.0.0a51 and 9.0.0a52 and 9.0.0a53 and 9.0.0a54 and 9.0.0a55 and 9.0.0a56 and 9.0.0a57 and 9.0.0a58 and 9.0.0a59 and 9.0.0a60 and 9.0.0a61 and 9.0.0a62 and 9.0.0a63 and 9.0.0a64 and 9.0.0a66 and 9.0.0a67 and 9.0.0a68 and 9.0.0a69 and 9.0.0a70 and 9.0.0 - 9.0.2 and 9.0.4 - 9.1.9

Summary

DIRAC is vulnerable to RCE in RequestManager due to eval on untrusted input

Details

Summary

An remote code execution vulnerability exists in RequestManager due to the use of eval on untrusted input that allows any authenticated user to run code/commands on the DIRAC server as the system user running the DIRAC services.

Details

The export_getRequestCountersWeb function is callable by any authenticated user and just passes its parameters directly to the database instance: https://github.com/DIRACGrid/DIRAC/blob/f7e0a3ac153315030fb3520e8ca747f013758967/src/DIRAC/RequestManagementSystem/Service/ReqManagerHandler.py#L270

If the groupingAttribute string is unrecognised, Request. is prepended to it and the result is passed into an eval() call: https://github.com/DIRACGrid/DIRAC/blob/f7e0a3ac153315030fb3520e8ca747f013758967/src/DIRAC/RequestManagementSystem/DB/RequestDB.py#L766-L776

By passing in a dunder string that is applicable to the Request object, it's possible to work back up to functions in the os module and trigger them to be called in the server context.

There are other uses of eval in ReqManager/RequestDB which may be equally accessible.

Impact

This allows any authenticated user to run commands on the server, which allows a full compromise of the DIRAC system (they can read the local dirac.cfg, get database passwords and export all stored proxies and tokens). If local logging is used, they can also remove evidence of the exploit from the log (it leaves an exception printout in the RequestManager log when used).