Vulnerability GHSA-7xw9-549r-8jrc

High Risk

4 months ago

DIRAC: SQL injection and lack of access control in PilotManager service

7.2a29 and 7.2.0a32 and 7.2.0a33 and 7.2.0a34 and 7.2.0a35 and 7.2.0a36 and 7.2.0a38 and 7.2.0a39 and 7.2.0 - 7.2.10 and 7.2.12 - 7.2.16 and 7.2.19 - 7.2.28 and 7.2.30 - 7.3.0a2 and 7.3.0a3 and 7.3.0a4 and 7.3.0a5 and 7.3.0a6 and 7.3.0a7 and 7.3.0a8 and 7.3.0a9 and 7.3.0a10 and 7.3.0a11 and 7.3.0a13 and 7.3.0a14 and 7.3.0a15 and 7.3.0a16 and 7.3.0a17 and 7.3.0a18 and 7.3.0a19 and 7.3.0a20 and 7.3.0a21 and 7.3.0a22 and 7.3.0a23 and 7.3.0a24 - 7.3.24 and 7.3.26 - 8.0.0a1 and 8.0.0a5 and 8.0.0a6 and 8.0.0a7 and 8.0.0a8 and 8.0.0a9 and 8.0.0a10 and 8.0.0a11 and 8.0.0a12 and 8.0.0a13 and 8.0.0a14 and 8.0.0a15 and 8.0.0a16 and 8.0.0a17 and 8.0.0a18 and 8.0.0a19 and 8.0.0a20 and 8.0.0a21 and 8.0.0a22 and 8.0.0a23 and 8.0.0a24 and 8.0.0a25 and 8.0.0a26 and 8.0.0a27 and 8.0.0a28 and 8.0.0a29 and 8.0.0 - 8.0.56 and 8.0.58 - 8.1.0a1 and 8.1.0a2 and 8.1.0a3 and 8.1.0a4 and 8.1.0a5 and 8.1.0a6 and 8.1.0a7 and 8.1.0a8 and 8.1.0a9 and 8.1.0a10 and 8.1.0a11 and 8.1.0a12 and 8.1.0a13 and 8.1.0a14 and 8.1.0a15 and 8.1.0a16 and 8.1.0a17 and 8.1.0a18 and 8.1.0a19 and 8.1.0a20 and 8.1.0a21 and 8.1.0a22 and 8.1.0a23 - 9.0.0a1 and 9.0.0a2 and 9.0.0a3 and 9.0.0a4 and 9.0.0a5 and 9.0.0a6 and 9.0.0a10 and 9.0.0a11 and 9.0.0a12 and 9.0.0a13 and 9.0.0a16 and 9.0.0a17 and 9.0.0a18 and 9.0.0a19 and 9.0.0a20 and 9.0.0a21 and 9.0.0a22 and 9.0.0a23 and 9.0.0a24 and 9.0.0a25 and 9.0.0a26 and 9.0.0a27 and 9.0.0a28 and 9.0.0a29 and 9.0.0a30 and 9.0.0a31 and 9.0.0a35 and 9.0.0a36 and 9.0.0a37 and 9.0.0a38 and 9.0.0a39 and 9.0.0a40 and 9.0.0a41 and 9.0.0a42 and 9.0.0a43 and 9.0.0a44 and 9.0.0a45 and 9.0.0a46 and 9.0.0a47 and 9.0.0a48 and 9.0.0a49 and 9.0.0a50 and 9.0.0a51 and 9.0.0a52 and 9.0.0a53 and 9.0.0a54 and 9.0.0a55 and 9.0.0a56 and 9.0.0a57 and 9.0.0a58 and 9.0.0a59 and 9.0.0a60 and 9.0.0a61 and 9.0.0a62 and 9.0.0a63 and 9.0.0a64 and 9.0.0a66 and 9.0.0a67 and 9.0.0a68 and 9.0.0a69 and 9.0.0a70 and 9.0.0 - 9.0.2 and 9.0.4 - 9.1.9

Summary

DIRAC: SQL injection and lack of access control in PilotManager service

Details

A number of the functions in PilotManager pass parameters directly through to the database layer, which then does not do any escaping on the parameters. For example setPilotStatus: https://github.com/DIRACGrid/DIRAC/blob/1738e7c6d2f31d26f1364255d9d2e87b4896c922/src/DIRAC/WorkloadManagementSystem/Service/PilotManagerHandler.py#L343-L349

https://github.com/DIRACGrid/DIRAC/blob/1738e7c6d2f31d26f1364255d9d2e87b4896c922/src/DIRAC/WorkloadManagementSystem/DB/PilotAgentsDB.py#L117

This won't accept multiple statements separated by a semicolon, but a carefully crafted set of parameters containing SQL escapes would likely be able to change or return other database entries.

Further to this, the PilotManager access control is only set to "authenticated"; this allows these functions to be called by any user. This allows any user to manage (e.g. delete, read output of) any pilot pilot job: https://github.com/DIRACGrid/DIRAC/blob/1738e7c6d2f31d26f1364255d9d2e87b4896c922/src/DIRAC/WorkloadManagementSystem/ConfigTemplate.cfg#L111-L118

This is fixed by changing the SQL statements to use proper parameter substitution and providing a suitable set of access rules for the exported pilot management functions.