Vulnerability GHSA-vg99-gr89-qhw9

High Risk

4 months ago

DIRAC: Pilot code downloaded over unverified HTTPS connection

7.2a29 and 7.2.0a32 and 7.2.0a33 and 7.2.0a34 and 7.2.0a35 and 7.2.0a36 and 7.2.0a38 and 7.2.0a39 and 7.2.0 - 7.2.10 and 7.2.12 - 7.2.16 and 7.2.19 - 7.2.28 and 7.2.30 - 7.3.0a2 and 7.3.0a3 and 7.3.0a4 and 7.3.0a5 and 7.3.0a6 and 7.3.0a7 and 7.3.0a8 and 7.3.0a9 and 7.3.0a10 and 7.3.0a11 and 7.3.0a13 and 7.3.0a14 and 7.3.0a15 and 7.3.0a16 and 7.3.0a17 and 7.3.0a18 and 7.3.0a19 and 7.3.0a20 and 7.3.0a21 and 7.3.0a22 and 7.3.0a23 and 7.3.0a24 - 7.3.24 and 7.3.26 - 8.0.0a1 and 8.0.0a5 and 8.0.0a6 and 8.0.0a7 and 8.0.0a8 and 8.0.0a9 and 8.0.0a10 and 8.0.0a11 and 8.0.0a12 and 8.0.0a13 and 8.0.0a14 and 8.0.0a15 and 8.0.0a16 and 8.0.0a17 and 8.0.0a18 and 8.0.0a19 and 8.0.0a20 and 8.0.0a21 and 8.0.0a22 and 8.0.0a23 and 8.0.0a24 and 8.0.0a25 and 8.0.0a26 and 8.0.0a27 and 8.0.0a28 and 8.0.0a29 and 8.0.0 - 8.0.56 and 8.0.58 - 8.1.0a1 and 8.1.0a2 and 8.1.0a3 and 8.1.0a4 and 8.1.0a5 and 8.1.0a6 and 8.1.0a7 and 8.1.0a8 and 8.1.0a9 and 8.1.0a10 and 8.1.0a11 and 8.1.0a12 and 8.1.0a13 and 8.1.0a14 and 8.1.0a15 and 8.1.0a16 and 8.1.0a17 and 8.1.0a18 and 8.1.0a19 and 8.1.0a20 and 8.1.0a21 and 8.1.0a22 and 8.1.0a23 - 9.0.0a1 and 9.0.0a2 and 9.0.0a3 and 9.0.0a4 and 9.0.0a5 and 9.0.0a6 and 9.0.0a10 and 9.0.0a11 and 9.0.0a12 and 9.0.0a13 and 9.0.0a16 and 9.0.0a17 and 9.0.0a18 and 9.0.0a19 and 9.0.0a20 and 9.0.0a21 and 9.0.0a22 and 9.0.0a23 and 9.0.0a24 and 9.0.0a25 and 9.0.0a26 and 9.0.0a27 and 9.0.0a28 and 9.0.0a29 and 9.0.0a30 and 9.0.0a31 and 9.0.0a35 and 9.0.0a36 and 9.0.0a37 and 9.0.0a38 and 9.0.0a39 and 9.0.0a40 and 9.0.0a41 and 9.0.0a42 and 9.0.0a43 and 9.0.0a44 and 9.0.0a45 and 9.0.0a46 and 9.0.0a47 and 9.0.0a48 and 9.0.0a49 and 9.0.0a50 and 9.0.0a51 and 9.0.0a52 and 9.0.0a53 and 9.0.0a54 and 9.0.0a55 and 9.0.0a56 and 9.0.0a57 and 9.0.0a58 and 9.0.0a59 and 9.0.0a60 and 9.0.0a61 and 9.0.0a62 and 9.0.0a63 and 9.0.0a64 and 9.0.0a66 and 9.0.0a67 and 9.0.0a68 and 9.0.0a69 and 9.0.0a70 and 9.0.0 - 9.0.2 and 9.0.4 - 9.1.9

Summary

DIRAC: Pilot code downloaded over unverified HTTPS connection

Details

Summary

The second stage pilot (pilot.tar) is downloaded by the initial wrapper script without any verification of the webservers' SSL certificate and the contained script is subsequently executed. The checksum is tested, but the reference checksum file is downloaded over the same unvalidated channel.

Details

The pilot wrapper downloads and executes the main second stage pilot script, but the SSL validation on this connection is explicitly disabled (to match old python < 2.7.9 behaviour): https://github.com/DIRACGrid/DIRAC/blob/integration/src/DIRAC/WorkloadManagementSystem/Utilities/PilotWrapper.py#L292-L296

This means that the second stage pilot code is not verified in any way and could potentially be altered by a man-in-the-middle attack to execute arbitrary code in the pilot context (i.e. with access to the pilot proxy/credentials).

The HTTPS connection should be validated against both the system certificates and $X509_CERT_DIR and fail if neither validate correctly.

Impact

This would require a man-in-the-middle style attack against a grid site's network (i.e. changing the DNS or routing to redirect the pilot's connection); this is likely to be difficult which probably limits the potential impact.