Vulnerability GHSA-r9qp-pqx5-8369
Summary
contao/core-bundle: Non-admin users can self-grant permissions that implicitly make them administrators
Details
Commit 2b83a60f7763 (5.7.3) hardened the template editor: it added TemplateEditorModuleVoter + CheckTemplateEditorSaveListener so a non-admin cannot self-grant the tpl_editor backend module (editable PHP-capable templates permit server-side code execution). That voter supports only the modules field and the literal value tpl_editor.
The equally RCE-capable theme_import capability lives in a different field - the themes checkbox field (tl_user_group.php:98-105 options include theme_import; identical on tl_user.php:248-253) - which has no save_callback and no voter. TemplateEditorModuleVoter is the only DC voter registered for tl_user_group, and it does not cover the themes field. So a delegated user manager can add theme_import to their own (or a managed) account.
Live repro (Contao 5.7.9):
- As admin, create a non-admin backend group with the
user(orgroup) module (a delegated user manager), and a user in it. Confirm the user cannot accesstpl_editor(blocked by the 5.7.3 voter). - As that non-admin, edit a group/account: add
themesto the modules field andtheme_importto the themes field (both accepted - onlytpl_editoris blocked). Re-authenticate.
Impact
A delegated user/group manager (a role explicitly not trusted with template/code access) escalates to arbitrary PHP execution on the server, fully compromising the installation. This bypasses the exact protection the 5.7.3 tpl_editor fix introduced.
Credits
This security vulnerability was found by @HDWSec
Related Vulnerabilities
Other vulnerabilities affecting the same packages