Vulnerability GHSA-p67v-3w7g-wjg7

Low Risk

4 months ago

Nokogiri: Possible Use-After-Free when directly using `NokogirI::XML::XPathContext` beyond document lifetime

1.0.0 - 1.4.2 and 1.4.2.1 and 1.4.3 and 1.4.3.1 and 1.4.4 and 1.4.4.1 and 1.4.4.2 and 1.4.5 - 1.4.7 and 1.5.0.beta.1 and 1.5.0.beta.2 and 1.5.0.beta.3 and 1.5.0.beta.4 and 1.5.0 and 1.5.1.rc1 and 1.5.1 - 1.5.2 and 1.5.3.rc2 and 1.5.3.rc3 and 1.5.3.rc4 and 1.5.3.rc5 and 1.5.3.rc6 and 1.5.3 and 1.5.4.rc1 and 1.5.4.rc2 and 1.5.4.rc3 and 1.5.4 and 1.5.5.rc1 and 1.5.5.rc2 and 1.5.5.rc3 and 1.5.5 and 1.5.6.rc1 and 1.5.6.rc2 and 1.5.6.rc3 and 1.5.6 and 1.5.7.rc1 and 1.5.7.rc2 and 1.5.7.rc3 and 1.5.7 - 1.5.11 and 1.6.0.rc1 and 1.6.0 - 1.6.1 and 1.6.2.rc1 and 1.6.2.rc2 and 1.6.2.rc3 and 1.6.2 and 1.6.2.1 and 1.6.3.rc1 and 1.6.3.rc2 and 1.6.3.rc3 and 1.6.3 and 1.6.3.1 and 1.6.4 and 1.6.4.1 and 1.6.5 and 1.6.6.1 and 1.6.6.2 and 1.6.6.3 and 1.6.6.4 and 1.6.7.rc2 and 1.6.7.rc3 and 1.6.7.rc4 and 1.6.7 and 1.6.7.1 and 1.6.7.2 and 1.6.8.rc1 and 1.6.8.rc2 and 1.6.8.rc3 and 1.6.8 and 1.6.8.1 and 1.7.0 and 1.7.0.1 and 1.7.1 - 1.8.5 and 1.9.0.rc1 and 1.9.0 - 1.9.1 and 1.10.0.rc1 and 1.10.0 - 1.10.10 and 1.11.0.rc1 and 1.11.0.rc2 and 1.11.0.rc3 and 1.11.0.rc4 and 1.11.0 - 1.11.7 and 1.12.0.rc1 and 1.12.0 - 1.13.10 and 1.14.0.rc1 and 1.14.0 - 1.15.7 and 1.16.0.rc1 and 1.16.0 - 1.17.2 and 1.18.0.rc1 and 1.18.0 - 1.19.3

Summary

Nokogiri: Possible Use-After-Free when directly using `NokogirI::XML::XPathContext` beyond document lifetime

Details

Summary

Nokogiri::XML::XPathContext did not keep its source document alive for garbage collection. If an XPathContext outlived its document and the document was collected, evaluating an XPath expression could read invalid memory and potentially segfault.

This is only reachable when application code constructs an XPathContext directly and lets the document become unreachable while continuing to use the context. The normal Document#xpath, #css, and related search methods are not affected, and it is not triggerable by malicious document input.

Nokogiri 1.19.4 makes XPathContext keep its source document alive for as long as the context exists.

Only the CRuby implementation is affected. JRuby is not affected.

Severity

The Nokogiri maintainers have evaluated this as low severity. Reaching it requires an unusual API-usage pattern that does not arise during normal use. The application must construct an XML::XPathContext directly and continue using it after allowing its source document to be garbage-collected. Nokogiri 1.19.4 makes this pattern safe with no change to the public API. The context now keeps its source document alive for as long as it exists.

Mitigation

Upgrade to Nokogiri 1.19.4 or later.

As a workaround, ensure the source document remains referenced for as long as any XPathContext created from it is in use. The standard Document#xpath, #css, and related search methods already do this and are unaffected.