Vulnerability GHSA-474x-hrwr-fgx4
Summary
fast-xml-parser: Quadratic CPU consumption scanning unterminated stop-node tags
Details
Summary
With the non-default stopNodes option, a stop node's body with many "<a " fragments and no closing ">" anywhere after makes readStopNodeData() rescan the entire remaining input from every "<". The failed lookahead is neither cached nor bounded, so n fragments cost O(n²) before the parser throws. Availability-only (CPU exhaustion), needs the non-default stopNodes option — not benchmarked yet, see Proof of Concept.
Details
CWE-407 — Inefficient Algorithmic Complexity
Code
OrderedObjParser.js:520—parseXml()callsreadStopNodeData()after a matching stop node opensOrderedObjParser.js:810— callsreadTagExp()for every non-special<OrderedObjParser.js:688-722—tagExpWithClosingIndex()scans to end-of-input and returnsundefinedwhen no>existsOrderedObjParser.js:812-818— on failure,iisn't advanced, so the next<repeats the same full scanOrderedObjParser.js:423— the main parse loop throws immediately on the same failure; only the stop-node path retries
Root cause: a failed closing-> lookahead is neither cached nor bounded — n copies of <a with no later > means n scans over the remaining input, O(n²) work, before it finally throws.
Fix
- Throw immediately in
readStopNodeData()whenreadTagExp()returnsundefined - Or break the loop on the first failed scan
- Or find the next
>once and reuse/bound that result - Add a test asserting near-linear scaling when payload size doubles
Proof of concept
Not benchmarked — static-analysis finding, confidence 0.5.
To confirm: configure stopNodes matching a root element. Build input as '<stop>' + '<a '.repeat(n). Time parse() until it throws Unexpected end of <tag>. Start around n=10,000 and double it — quadratic should show ~4x time per doubling, linear ~2x. Control: same input with a > present, or stopNodes unset.
Impact
CPU-exhaustion DoS in Node.js services parsing untrusted XML with stopNodes enabled. A ~100KB payload is estimated at ~10⁹ character operations (roughly a second or more of blocked event loop) — analytical estimate, not a benchmark. No confidentiality/integrity impact. CVSS 3.1: AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:L (3.7, Low).
Related Vulnerabilities
Other vulnerabilities affecting the same packages